Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote: Possibly yes. I have a patch
Abdelrazak> pending for that issue that is not OKed AFAIS. Could you
Abdelrazak> try it?
I tried this one but cannot compile:
Abdelrazak> Sorry, try this one.
This seems to work
OK, as this is a fix to a crash and that it also addresses Andre' main
complaint about the memory consumption due to the boost::signal in the
Inset class I'll commit.
(which does not mean that I like this signal
approach, of course!).
Which is of course independant of whether this fix is correct or not. If
you have the time you could try to implement the alternative solution
proposed by Alfredo (checking inset validity from top to tip in
fixIfBroken). But I don't really understand why you think the signal
solution is bad. This is the *only* way to ensure that the inset pointer
inside CursorSlice is valid at any time. Even with Alfredo solution you
could end up with an invalid pointer if you forgot to call fixIfBroken().
Abdel.
