Am 30.05.2007 um 23:32 schrieb Lars Gullik Bjønnes:
[EMAIL PROTECTED] writes: | Author: sts | Date: Wed May 30 21:38:22 2007 | New Revision: 18580 | | URL: http://www.lyx.org/trac/changeset/18580 | Log: | * avoid redraw if possible (OK by Abdel and Dov) | | Modified: | lyx-devel/trunk/src/Cursor.cpp | lyx-devel/trunk/src/Cursor.h | lyx-devel/trunk/src/Text3.cpp | | Modified: lyx-devel/trunk/src/Cursor.cpp| URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/Cursor.cpp? rev=18580 | ====================================================================== ========| --- lyx-devel/trunk/src/Cursor.cpp (original) | +++ lyx-devel/trunk/src/Cursor.cpp Wed May 30 21:38:22 2007 | @@ -1168,7 +1168,7 @@ | } | | | -bool Cursor::upDownInText(bool up) | +bool Cursor::upDownInText(bool up, bool & updateNeeded) Was this really thought through? Or do we now have two methods to signal "updateNeeded", flag and this ref? The second var really looks bad.
That's the way the dispatch handlers work in the Text class. In the dispatch method this updateNeeded flag is used everywhere. I didn't change the structure. If you want to do that (in a clean way than the updateNeeded logic), feel free to post a patch. I am happy to review it.
Stefan
PGP.sig
Description: Signierter Teil der Nachricht