Michael Gerz wrote:
> [EMAIL PROTECTED] schrieb:
>> Author: rgheck
>> Date: Mon May 21 17:34:29 2007
>> New Revision: 18445
>>
>> @@ -405,6 +410,18 @@
>>          return 0;
>>  
>> +    if (buffer.fileName() == included_file.toFilesystemEncoding()) {
>> +        Alert::error(_("Recursive input"), +                      
>> bformat(_("Attempted to include file %1$s in itself! "
>> +                       "Ignoring inclusion."), from_utf8(incfile)));
>> +        return 0;
>> +    }
>> +
>>  
>> @@ -560,6 +577,17 @@
>>  
>> +    if (buffer.fileName() == included_file) {
>> +        Alert::error(_("Recursive input"), +                      
>> bformat(_("Attempted to include file %1$s in itself! "
>> +                       "Ignoring inclusion."), from_utf8(incfile)));
>> +        return 0;
>> +    }
>> +
>>   
> once you use "included_file" and once
> "include_file.toFilesystemEncoding()". This looks highly suspicious.
The variables are different, though named the same (not my doing). In
the former case, it is:
    FileName const included_file(includedFilename(buffer, params_));
In the latter:
    string const included_file = includedFilename(buffer,
params_).absFilename();
Still, the former call should really be absFilename(), not
toFilesystemEncoding(), since that's what Buffer::fileName() uses.

Richard


-- 
==================================================================
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==================================================================
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto

Reply via email to