Stefan Schimanski wrote:

Am 24.05.2007 um 23:56 schrieb Dov Feldstern:

Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!

Is it a bug or a feature that the cursor does not enter insets from the right in the text? In Text::cursorLeft the checkAndActivateInset(cur, false) call comes before moving the cursor from the right. Though checkAndActivateInset expects the cursor to be left of the inset to enter. I guess that's not was is expected, right?

Stefan

Hi!
I'm almost certainly responsible for this --- I basically rewrote cursorLeft recently, in order to solve the crash we were having with RTL on (http://www.lyx.org/trac/changeset/18389). However, I'm not sure I understand what the problem is? It seems to be working for me?
Dov

Please don't spend too much time. I have a working version I think here now and only workout some target_x bugs. Will probably send the patch to the list tomorrow.

Stefan


Thanks, but I actually think I've got a solution, too: the cause (I think --- haven't tested yet) is the condition "if (cur.pos() == cur.lastpos()) return false" at the beginning of checkAndActivateInset. It should either read "if (cur.pos() == cur.lastpos() && front)", or else we can really get rid of it all together --- I think it's just an easy way of exiting early, before doing more expensive checks...

Dov

Reply via email to