On Wednesday 16 May 2007 00:33:52 Dov Feldstern wrote: > Hi! > > Sorry for only replying now --- if I'm too late for beta3, then this is > still relevant for afterwards:
Because of my email server failure this is not too late. This is also the last changes I will do before releasing beta-3. > *) As Abdel said, Mostafa's Farsi patches should, I think, go in. I > tested them at some point to make sure that it doesn't break Arabic or > Hebrew (I don't know Farsi), and it was okay. I'm a little confused, > though, as to their current status --- especially regarding the > ArabTeX/Arabi issue --- so I'm not sure that what I tested was the > latest version. Don't hold this up for me, however --- I won't be able > to check it again before the weekend... I agree that Mostafa patch should go, but I have not yet decided what to do regarding the file format. Eventually I think that a back convertion to 1.4 is not desirable in this case and then we have two choices, either we don't do nothing and apply the code as is or we increase the file format and assert if a Farsi document is reverted to 1.4. Nevertheless no matter what the decision is this patch will go before the next release. > *) I would be happy if the very minor attached patch, which marks spaces > which belong to a foreign language in the same manner that > non-whitespace is marked, could go in. This is helpful especially in > bidi situations for understanding where exactly the languages switch. > > Georg has approved of the approach (he agrees that spaces should > definitely be marked), but said he doesn't know the relevant code well > enough to vouch for its correctness > (http://permalink.gmane.org/gmane.editors.lyx.devel/81153 --- and there > are more details in that thread). I've been working with this patch > applied since I first submitted it a month ago, and have run into no ill > effects. This can go. > *) Elazar's math cut&paste issue --- I can't reproduce, see > http://permalink.gmane.org/gmane.editors.lyx.devel/83938 Abdel, what do you think? I trust you judgment in the issue, if the code is OK with you it can go. > *) my RTL crash fix, see separate discussion at > http://permalink.gmane.org/gmane.editors.lyx.devel/83924 This should go. > Those are the patches that I have in my queue at the moment. > > Thanks! > Dov Thanks for the feedback. :-) -- José Abílio
