Bo Peng wrote: > A few questions: > > 1. You mentioned file format change but no lyx2lyx stuff in your patch.
I haven't done anything yet. Perhaps we don't need it, since no LyX version with listings hasn't been released yet. That's why I like to have it included before the next beta. > 2. Should caption be removed from the listings dialog? Or should the > caption inset automatically reflects the changes there? it should be removed (along with label). > 3. I think that this caption stuff is more important in the > insert->child document dialog, because listings inset tends to replace > small code pieces (maybe originally in lyx-code environment) without > caption, and \lstinputlisting tends to have a big trunk of code that > needs a caption. I think you should provide a caption anywhere (except for inline listings, where it is suppressed by listings.sty anyway). If necessary, show the caption and label widgets only in the child document case, but hide it in the normal dialog. > We still get a chance to revoke all child document stuff and use the > listings inset to handle \lstinputlisting. The advantage is that > > 1. all three kinds of listings (inline, normal, file) are handled at > the same place. This is conceptually cleaner. > > 2. we do not need to call the listings dialog from the include child > document dialog. > > 3. Frankly, insert a file using that dialog is cumbersome. > (insert->child document, browse, choose type, no way to enter > caption...). > > What do you think? What if the user can insert a child document _inside_ the listings "float"? Then he can insert an ordinary caption above it, and he can set the params with the dialog as usual. > Cheers, > Bo Jürgen
