Bo Peng wrote:
Attached please find a much improved InsetListings patch. The
implementation can now be reviewed...

i only took a look at the result (not the code), and it made me wonder what exactly is gained by this?

some impressions:

implementation wise i find it strange to have code in a collapseable inset (i also tried ERT, as in attached, and found that this is pretty similar ui wise).

wouldn't you want to set "code listing" or something like that in the layout box and just start to type away?

also, why have code as a "child document"? i would think it fits more with "external material"

i am not a potential user, but i am not so sure that if you would design clean ui support it would look like this.

more importantly, i have the impression that this is a very big patch to get rid of very little ERT...

just my 2c of course (and definitely no flame!)

regards, ed.

finally, a little bug: when copy-pasting the inlined code, the inlined setting gets lost



Attachment: newfile3.lyx
Description: application/lyx

Reply via email to