Georg Baum wrote:
Abdelrazak Younes wrote:
Georg Baum wrote:
And then look at the very recent marginal bug: AFAIK (correct me if I am
wrong) this happened because of missing review of the insetName -> name
change.
Small correction: this bug appeared in the InsetOld -> Inset transfer
with the removal of setInsetName(). Nothin to do with the insetName ->
name change.
Thanks for the correction. It does not change much: I just looked it up,
that rename also went in without review.
I think I've warned that I will do it. There was not much to review
IMHO, but anyway point taken.
A simple and safe looking change caused a serious bug.
About this particular one, I proposed to make the method pure virtual,
any objection?
Looks good provided you are 100% sure that the names are correct.
JMarc is not in favour so I postpone this to 1.6. I've reviewed the
InsetOld removing commit and I don't think there was any other error
than the "Marginal" one.
Abdel.
