Re: antialiasing in formulas

[Stefan Schimanski]

Thanks!

Stefan

Edwin Leuven wrote:

i have switched to svn for my daily work now (don't miss good old 1.4.3 for one second!!)

however, i *strongly* suggest that we revert this patch:
http://www.lyx.org/trac/changeset/17639

1. the result is actually not nice, but rather fuzzy

and get rid of the antialiasing in formulas for the following two reasons: 2. the mixing of antialiased text with non-antialiased text is really ugly

Please try again.

Author: younes
Date: Fri May  4 11:24:44 2007
New Revision: 18197

URL: http://www.lyx.org/trac/changeset/18197
Log:


Modified:
    lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp

Modified: lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp

* QLPainter: antialias edges of primitives only if text is antialiased. URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/frontends/qt4/ QLPainter.cpp?rev=18197 ====================================================================== ========

--- lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp (original)

@@ -98,7 +98,8 @@
                return;

        setQPainterPen(col, ls, lw);
-       bool const do_antialiasing = x1 != x2 && y1 != y2;
+       bool const do_antialiasing = renderHints() & TextAntialiasing
+               && x1 != x2 && y1 != y2;
        setRenderHint(Antialiasing, do_antialiasing);
        drawLine(x1, y1, x2, y2);
        setRenderHint(Antialiasing, false);
@@ -113,10 +114,11 @@
        if (!isDrawingEnabled())
                return;

+       bool const text_is_antialiased = renderHints() & TextAntialiasing;
        setQPainterPen(col, ls, lw);
        for (int i = 1; i < np; ++i) {
-               bool const do_antialiasing = false &&
-                       xp[i-1] != xp[i] && yp[i-1] != yp[i];
+               bool const do_antialiasing = text_is_antialiased
+                       && xp[i-1] != xp[i] && yp[i-1] != yp[i];
                setRenderHint(Antialiasing, do_antialiasing);
                drawLine(xp[i-1], yp[i-1], xp[i], yp[i]);
                setRenderHint(Antialiasing, false);
@@ -151,7 +153,7 @@

        // LyX usings 1/64ths degree, Qt usings 1/16th
        setQPainterPen(col);
-       bool const do_antialiasing = true;
+       bool const do_antialiasing = renderHints() & TextAntialiasing;
        setRenderHint(Antialiasing, do_antialiasing);
        drawArc(x, y, w, h, a1 / 4, a2 / 4);
        setRenderHint(Antialiasing, false);

+++ lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp Fri May 4 11:24:44 2007

PGP.sig
Description: Signierter Teil der Nachricht