Bo Peng wrote:
Ouch... this is a big, non obvious, patch Bo... I am not sure we will
find the time to properly review it and add the missing bits before
1.5.0 :-(
InsetListings ~= InsetERT so you do not have to pay much attention to
it, other than the InsetListingsParams part.
Than why don't you merge the two instead? Or inherit from it? I
personally really dislike code repetition, this is asking for trouble
later on.
Many other small changes are startard methods to add dialog, add
require('listings') and add the inset itself. They can be ignored as
well.
I'll try to have a look this week-end. But do we really need this dialog
now?
What I need from you is the qt4/QListings.* and qt4/ui/ListingUi.ui
part. You can get the parameters and put them to the listWidget, when
one of the items is clicked, its value goes to the editbox and when
the focus leaves the editbox, its value should be saved in the
listwidget. Then, the parameters are returned to the inset. If you are
not sure how parameters are passed, I am not sure either, but I copied
the code from QWrap. :-) InsetWrap has something like InsetWrapParams
as well.
Why don't you copy the code architecture from one of the new dialogs
instead: View source is easy enough and you'll find your way in it.
If you can find a clever way to put this dialog to insert -> include
(as the fourth file type), then we can easily have \lstinputlisting.
If you can put it also to file -> settings, then we can have proper
\lstset in the preamble.
I have to apply and test the patch to understand what you mean. Not
before the week-end. I do not promise anything though because I already
have some bug-fixing patches in the pipe and these have higher priority.
Abdel.
