On Thursday 26 April 2007 5:45:26 pm Uwe Stöhr wrote:
>  >> Can I apply it?
>  >
>  >  Please fill the file format change in development/FORMAT as well.
>
> Of course I will do this, what about the patch? The lyx2lyx stuff is
> working for me and I tested it well I think, but is this also fine for you?

  Yes, it looks sane. I can make some remarks about the code but they are 
minor:

  - You initialise both h and k outside the loop, there is no need, you can  
remove that definition and the code will work the same.

  - The code is inefficient, it will run over all lines even if you don't have 
any table in the document. Again this can be changed later if the profiler 
shows that there is a significant lag do to this code.

  So regarding the lyx2lyx part the code is OK, so this can go in.

> regards Uwe

-- 
José Abílio

Reply via email to