On Tue, Apr 03, 2007 at 03:32:51PM -0400, Richard Heck wrote:
> 
> I found the source of the error:
> QWidget::setMinimumSize: (QGraphicsUi/lyx::frontend::QGraphicsDialog)
> Negative sizes (-1,-1) are not possible
> that I've been getting with the graphics dialog. In QDialogView::show()
> we have:
>     form()->setMinimumSize(form()->sizeHint());
> but QGraphicsDialog returns an invalid size hint, since the widget as a
> whole has no layout. So it seems to me that we'd be better off with:
>     if (form()->sizeHint().isValid())
>         form()->setMinimumSize(form()->sizeHint());
> Yes?
> 
> If that seems OK, I'll commit it.

Note that the culprits here are

http://www.lyx.org/trac/changeset/17625
http://www.lyx.org/trac/changeset/17626

Moreover, on Qt 4.1.4 the Browse and Edit buttons were the same size
without those patches and are of different size with them.
So I simply propose to correct the bugs introduced by changesets 17625
and 17626 or to revert them.

-- 
Enrico

Reply via email to