Andre Poenitz wrote:
On Tue, Mar 27, 2007 at 02:00:13PM +0200, Abdelrazak Younes wrote:
One tiny comment: maybe you could use a boost::scoped_ptr instead of a
raw pointer for undo::pars?
*shrug* I don't see the benefit. I put ASSERTs all over the place
to make sure we walk on the safe side.
That's the point really: less loc and be on the safe side if someone
else less paranoid than you use the pointer ;-)
If someone else wants to waste cycles - fine with me.
I don't care much anyway... Please put it in then.
By the way, there's a new mathed and undo related crash (which your
patch does not fix):
http://bugzilla.lyx.org/show_bug.cgi?id=3358
I'll have a look later.
Thanks,
Abdel.
