Andre Poenitz wrote:
> On Mon, Mar 26, 2007 at 08:49:49PM +0200, Peter Kümmel wrote:
>> Andre Poenitz wrote:
>>> On Mon, Mar 26, 2007 at 06:37:12PM +0200, Jean-Marc Lasgouttes wrote:
>>>>>>>>> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>>>> Andre> On Mon, Mar 26, 2007 at 05:49:13PM +0200, Jean-Marc Lasgouttes
>>>> Andre> wrote:
>>>>>>>>>>> "Andre" == Andre Poenitz
>>>>>> <[EMAIL PROTECTED]> writes:
>>>>>>
>>>> Andre> On Sun, Mar 25, 2007 at 10:04:01PM -0000, [EMAIL PROTECTED]
>>>> Andre> wrote:
>>>>>>>> +find_package(ICONV REQUIRED) +add_definitions(-DHAVE_ICONV=1)
>>>> Andre> So some libiconv is still required?
>>>>>>  glibc has the iconv api, so libiconv is not needed in linux.
>>>> Andre> I know that since yesterday or so, it's just cmake
>>>> Andre> unconditionally requiring it right now.
>>>>
>>>> I thought you missed that message from Georg. And it seems that I
>>>> cannot grok cmake language (I'll rewrite that in m4 in due time :)
>>> C
>>> C     IF IT WEREN_T FOR THAT ALL_CAPS STUFF...
>>> C      
>>>
>>> ANDRE_
>>>
>> cmake is only case sensitive on variable names. So we are only forced
>> to use upper case letters when we handle cmake default variables.
>> Feel free to change it.
> 
> I'd prefer lower case whenever possible. Otherwise I really have this
> FORTRAN deja vu... I any case, we should try to use some consistent
> style.
> 
> Andre'
> 

No problem, we could always use lower case when it is possible.

-- 
Peter Kümmel

Reply via email to