Andre Poenitz wrote:
> On Wed, Mar 21, 2007 at 12:14:49AM +0100, Peter Kümmel wrote:
>> Index: src/support/filetools.C
>> ===================================================================
>> --- src/support/filetools.C (Revision 17495)
>> +++ src/support/filetools.C (Arbeitskopie)
>> @@ -67,7 +66,20 @@
>>
>> namespace fs = boost::filesystem;
>>
>> +#include <boost/lexical_cast.hpp>
>> +
>> namespace lyx {
>> +
>> +template<>
>> +string convert<string>(int i)
>> +{
>> + return boost::lexical_cast<string>(i);
>> +}
>> +
>> +}
>> +
>> +
>> +namespace lyx {
>> namespace support {
>>
>> bool isLyXFilename(string const & filename)
>> Index: src/support/convert.C
>> ===================================================================
>> --- src/support/convert.C (Revision 17495)
>> +++ src/support/convert.C (Arbeitskopie)
>> @@ -51,13 +51,6 @@
>>
>>
>> template<>
>> -string convert<string>(int i)
>> -{
>> - return lexical_cast<string>(i);
>> -}
>> -
>> -
>> -template<>
>> docstring convert<docstring>(int i)
>> {
>> return lyx::from_ascii(lexical_cast<string>(i));
>
>
> This looks safe to apply anyway.
No. IMHO the 'convert' template specializations should stay in one place
only. And I fail to understand why this patch is needed for concatenating
files.
Georg
PS: I fail to understand either why you bring up issues like compile times
and rpmdist. I thought that the goal was to get out 1.5.0 ASAP, but
obviously this is not true and it is more important to discuss some
fundamental changes like the mentioned issues or some future file format
changes.
