>> | -     connect(scaleCB, SIGNAL(clicked()),
>> | +     connect(scaleCB, SIGNAL(clicked() ),

> Rather remove the spaces instead of adding new ones... we do not use
> this kind of spacing elsewhere.

The whole file uses this spacing only this line not.

> 
http://www.lyx.org/trac/file/lyx-devel/trunk/src/insets/insetgraphicsParams.C?rev=17395
>
> | -     scale = string();                       // output scaling in 
percentage
> | +     scale = string("100");                  // output scaling in 
percentage
>
> This this hunk the actual bug fix?

Yes, simple isn't it ;-)

> I think it is better to do this kind of commits as two commits.

OK next time.

regards Uwe

Reply via email to