Bernhard Roider <[EMAIL PROTECTED]> writes:
| the patch...
I think the var "lastReadOk" should be mutable, and you should not
remove const from the functions.
| Index: src/lyxlex.h
| ===================================================================
| --- src/lyxlex.h (revision 17394)
| +++ src/lyxlex.h (working copy)
| @@ -101,16 +101,16 @@
| int getLineNo() const;
|
| ///
| - int getInteger() const;
| + int getInteger();
| ///
| - bool getBool() const;
| + bool getBool();
| ///
| - double getFloat() const;
| + double getFloat();
| ///
| - std::string const getString() const;
| + std::string const getString();
|
| ///
| - docstring const getDocString() const;
| + docstring const getDocString();
Do not remove const on these.
|
| /** Get a long string, ended by the tag `endtag'.
| This string can span several lines. The first line
| @@ -162,6 +162,8 @@
| class Pimpl;
| ///
| Pimpl * pimpl_;
| + ///
| + bool lastReadOk_;
make it mutable.
Apart from that I don't have an opinion on the patch.
--
Lgb
