Am Dienstag, 20. Februar 2007 20:13 schrieb Michael Gerz:
> Georg Baum schrieb:
> > This does not look right. All math plaintext output is done in 
> > InsetMathHull::plaintext(), the other plaintext methods are empty on 
> > purpose (they are not used because of the shortcut in 
> > InsetMathHull::plaintext()).
> >   
> And this is exactly the reason why I added some output in InsetMath. Not 
> all of its sub classes implement plaintext() and I want to get some 
> indication in plain text output if we forgot to implement it somewhere 
> accidentally.
> 
> Does this make sense to you?

No, I don't understand. AFAIK the only math inset that needs a plaintext 
method is InsetMathHull, because for all other math insets the plaintext 
method  is never called. If this is not true please explain how the 
plaintext method of math insets other than InsetMathHull is called.

If I am right then we should probably add a

BOOST_ASSERT(false);

in InsetMath::plaintext and explain why we do that.

> I have no intention to improve it ATM.

OK, it was just a suggestion because I did not understand the purpose of 
the change.


Georg

Reply via email to