On Feb 19, 2007, at 1:54 AM, Angus Leeming wrote:
Bennett Helm wrote: Bennett> ... With the patch, this time! Nitpicking to follow... ;-)Bennett> +echo "LYXCMD:macdvix:server-goto-file-row:"$file" $2" Why do you unquote $file? Please change to: echo "LYXCMD:macdvix:server-goto-file-row:$file $2"
I'm just following what was done before on the assumption that it's better than what I'd do on my own!
Bennett> +echo LYXCMD:macdvix:server-goto-file-row:"$file" $2
Bennett> > "${LYXPIPE}".in || exit
I'd change this to match the line above. Actually, I'd write:
MAC_LYXPIPE_CONTENTS="LYXCMD:macdvix:server-goto-file-row:$file $2"
echo "$MAC_LYXPIPE_CONTENTS"
echo "$MAC_LYXPIPE_CONTENTS" > "${LYXPIPE}".in || exit
Done (patch attached). Could someone please put this in? Thanks again, Angus. Bennett
mac-lyxeditor.diff
Description: Binary data
