Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:

| I was looking at add an lyxrc option \handle_x_deadkeys which could be
| set to false for people who want the normal dead keys handling, and
| saw several things:
| 
| - the bindings are not saved in a map. Lars did you do this just for
s/not/now?
O(log n) instead of O(n).
besides 
|   fun, or is there a real reason? The problem is that it makes things
|   a bit unpredictible, for example:
| 
|   # the second overrides the first
|   \bind "M-C-a" "foo"
|   \bind "M-C-a" "bar"
| 
|   # the first is kept, since bind() does not override
|   \bind "M-C-a" "foo"
|   \bind "C-M-a" "bar"

Ok this can be fixed by providing a more clever comparison operator
(functor). 
Was this any different earlier? (before kbmap rewrite)

| - the bindings member creates duplicates templates, for no apparent
|   gain (and I do not see how to `pimpl' it cleanly)

What template?
What do you want to pimpl? kb_keymap?

| - this adds some ugliness in lyx_main.C, that I'd rather see hidden in
|   lyxrc or keymaps.

What where?
Some of this is historical baggage.
The problem is the global vairables.

| - you do the bindings as early as possible. Is there a reason for
|   that? Can I move at least the deadkey bindings until after lyxrc has
|   been read?

Why? We want the hardcoded bindings to go in first.

        Lgb

Reply via email to