the attached patch gets rid of this one (and a crash)
i also got rid of 2 mailer updates which i think are not necessary since
workarea dispatch already updates the dialog on key and mouse events
(i might be wrong though)
can someone (uwe?) test it?
btw, is it necessary to update toolbars/dialogs both on mousepress and
mouserelease?
this tabular stuff (and its controller) are really evol. i intend to
clean up a bit for 1.6....
thanks
Index: src/frontends/qt4/QTabularDialog.C
===================================================================
--- src/frontends/qt4/QTabularDialog.C (revision 16692)
+++ src/frontends/qt4/QTabularDialog.C (working copy)
@@ -57,7 +57,8 @@
connect(interlinespaceUnit,
SIGNAL(selectionChanged(lyx::LyXLength::UNIT)),
this, SLOT(interlinespace_changed()));
connect(interlinespaceCO, SIGNAL(activated(int)), this,
SLOT(interlinespace_changed()));
- connect(booktabsRB, SIGNAL(clicked()), this,
SLOT(on_booktabsRB_toggled()));
+ connect(booktabsRB, SIGNAL(clicked(bool)), this,
SLOT(booktabsChanged(bool)));
+ connect(borderDefaultRB, SIGNAL(clicked(bool)), this,
SLOT(booktabsChanged(bool)));
connect(borderSetPB, SIGNAL(clicked()), this,
SLOT(borderSet_clicked()));
connect(borderUnsetPB, SIGNAL(clicked()), this,
SLOT(borderUnset_clicked()));
connect(longTabularCB, SIGNAL(toggled(bool)), longtableGB,
SLOT(setEnabled(bool)));
@@ -107,7 +108,7 @@
}
-void QTabularDialog::on_booktabsRB_toggled()
+void QTabularDialog::booktabsChanged(bool)
{
form_->changed();
form_->controller().booktabs(booktabsRB->isChecked());
Index: src/frontends/qt4/QTabularDialog.h
===================================================================
--- src/frontends/qt4/QTabularDialog.h (revision 16692)
+++ src/frontends/qt4/QTabularDialog.h (working copy)
@@ -35,7 +35,7 @@
virtual void topspace_changed();
virtual void bottomspace_changed();
virtual void interlinespace_changed();
- virtual void on_booktabsRB_toggled();
+ virtual void booktabsChanged(bool);
virtual void close_clicked();
virtual void borderSet_clicked();
virtual void borderUnset_clicked();
Index: src/frontends/qt4/ui/QTabularUi.ui
===================================================================
--- src/frontends/qt4/ui/QTabularUi.ui (revision 16692)
+++ src/frontends/qt4/ui/QTabularUi.ui (working copy)
@@ -315,6 +315,9 @@
<property name="text" >
<string>Fo&rmal</string>
</property>
+ <property name="checked" >
+ <bool>true</bool>
+ </property>
</widget>
</item>
<item row="0" column="0" >
Index: src/insets/insettabular.C
===================================================================
--- src/insets/insettabular.C (revision 16692)
+++ src/insets/insettabular.C (working copy)
@@ -1271,8 +1271,6 @@
}
cur.updateFlags(Update::Force | Update::FitCursor);
-
- InsetTabularMailer(*this).updateDialog(&bv);
}
@@ -1760,8 +1758,6 @@
case LyXTabular::LAST_ACTION:
break;
}
-
- InsetTabularMailer(*this).updateDialog(&bv);
}
