Georg Baum wrote:
Abdelrazak Younes wrote:
Georg Baum wrote:
Not all static variables are evil,
sometimes they are exactly the right tool for the right job.
Sure, when you know what you are doing...
Exactly. In this case, at a first glance, I think your suggestion to
transfer it to the buffer would also work (apart from const correctness),
but maybe there was another reason to make it static, I don't know.
Getting the labels can take that long because kpsewhich can be called
several times, and if you have a TeX installation with many files it can
really be slooooow.
I don't see this kpsewhich being called anywhere here. Could you please
enlighten us?
IIRC it is called indirectly via buffer.fillWithBibKeys().
I see. There's something wrong with nsetBibtex::getFiles(Buffer const &
buffer), buffer is not used at all. The local "vector<FileName> vec" in
this method is the one that needs to be cached.
Abdel.
