Abdel,
I have a few questions:
Log:
This commit fixes the singlePar optimization which was disabled due to the
ParagraphMetrics cleanup.
+ if (singlepar
+ // In Single Paragraph mode, rebreak only
+ // the (main text, not inset!) paragraph containing the cursor.
+ // (if this paragraph contains insets etc., rebreaking will
+ // recursively descend)
+ && tm.redoParagraph(cursor_.bottom().pit()))
+ singlepar = false;
Does this comment make sense here? AFAICS, we do not break the main text
(but bottom()).
URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/ParagraphMetrics.C?rev=16543
==============================================================================
--- lyx-devel/trunk/src/ParagraphMetrics.C (original)
+++ lyx-devel/trunk/src/ParagraphMetrics.C Sat Jan 6 10:15:59 2007
+size_type ParagraphMetrics::calculateRowSignature(Row const & row)
+{
+ boost::crc_32_type crc;
+ for (pos_type i = row.pos(); i < row.endpos(); ++i) {
+ char_type const b[] = { par_->getChar(i) };
+ crc.process_bytes(b, 1);
+ }
+ return crc.checksum();
+}
+
+
URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/rowpainter.C?rev=16543
==============================================================================
--- lyx-devel/trunk/src/rowpainter.C (original)
+++ lyx-devel/trunk/src/rowpainter.C Sat Jan 6 10:15:59 2007
@@ -823,20 +823,6 @@
}
-size_type calculateRowSignature(Row const & row, Paragraph const & par,
- int x, int y)
-{
- boost::crc_32_type crc;
- for (pos_type i = row.pos(); i < row.endpos(); ++i) {
- char_type const b[] = { par.getChar(i) };
- crc.process_bytes(b, 1);
- }
- char_type const b[] = { x, y, row.width() };
- crc.process_bytes(b, 3);
- return crc.checksum();
-}
Are you sure that there is no longer a need to consider x,y and
row.width() in calculateRowSignature()?
Michael
