On Sat, Apr 29, 2000 at 04:48:58PM +0200, Asger K. Alstrup Nielsen wrote:
> > I do know that the difference will not be noticeable by the user, but I think
> > that returning complex objects from functions should be avoided.
> 
> In general, it's more important for the code to be clear than for the
> code to be fast.  This rule should only be lifted if profiling shows
> that there is a performance problem.

Yes, but I think that the style I use is quite clear.
To refresh your memory, I've created a procedure
(1) void LyXParagraph::String(string & s)
that writes the paragraph into the string s.

The alternative is
(2) string LyXParagraph::String()
that returns a string from the paragraph.

Do you really think that (2) is clearer/better than (1) ?
Should I stay with (1) ?

> > I also thought of another idea: creating a references menu, that after you
> > select an item in this list, a sub-menu opens, letting you select from
> > inserting a reference/page number/jump to the reference.
> 
> That's a nice idea.  We are timing you to see a patch ;-)

I've implemented this feature, but I want to clean the code.

Reply via email to