Am Donnerstag, 4. Januar 2007 21:25 schrieb Abdelrazak Younes:
> Georg Baum wrote:
> > The attached patch actually triggers the redraw. Can you please tell me 
> > whether I did it right?

> +             buffer_->changed();
> 
> Of course this is about X11 so I cannot verify that this is correct.

Thanks, I did verify that it is correct. I'll put this one in.

> Note that buffer_->changed() will trigger a full updateMetrics() on all 
> other views that share the same buffer.

Since this can only occur as response to user input it is acceptable IMO.

> > If we want to implement approach A we should not not call 
> > cursor_.clearSelection() in BufferView::clearSelection(). The current 
code 
> > is neither correct for approach A nor for B.
> 
> Indeed and I would prefer that a lot.

We'll discuss that later. First I am going to fix the current 
implementation.


Georg

Reply via email to