Georg Baum wrote:
Am Mittwoch, 3. Januar 2007 23:48 schrieb Abdelrazak Younes:
Michael Gerz wrote:
[EMAIL PROTECTED] schrieb:
Modified: lyx-devel/trunk/src/TextMetrics.C
URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/TextMetrics.C?rev=16452
==============================================================================
[...]
Is this a real bug fix (addressing a cause) or just a workaround
(curing
the effect)?
Originally it was a work around a bug (curing the effect). The bug
vanished after my MVC cleanup. Peter estimated that the check was a
useful safeguard anyway.
I understood that that patch did not go in because your cleanup fixed the
bug otherwise, now I learn that it did. Please revert that. Workarounds
like this make the code less understandable. If you read that in 6 months
you will not know anymore that this was a workaround for a bug that does
no longer exists. That immediately leads to the assumption that
row.endpos() can be out of bounds, which is wrong.
Workarounds like this are IMO only acceptable if
a) they fix a real problem and
b) there is a comment that this is a workaround and why it is needed
FWIW, I agree. I only re-committed this because I erased accidentally
(svn really) Peter's commit. So Peter, as this is your commit, would you
like to take care of that please?
Abdel.
