>>>>> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes:

Enrico> Jean-Marc, may I apply the attached patch? It is unrelated to
Enrico> bug 2900.

It looks like a good idea, but wouldn't it be even better to replace
-       updated |= cursorUp(cur);
+
+       if (cur.inMathed())
+               updated |= cur.up();
+       else
+               updated |= cursorUp(cur);
by 
-       updated |= cursorUp(cur);
+       cur.dispatch(FuncRequest(LFUN_UP));

This would have the advantage to avoid special casing for mathed.

Anyway, I want this patch in 1.4. We may say that it could go as it is
in 1.4, but for 1.5, I think it would be better to simplify the code
now when re remember what it does.

Also, adding the updated flag that we do not use looks a bit weird to
me. At least for 1.4, it seems useless.

And I do not know whether the return value of cur.up() means 'updated'.

JMarc

Reply via email to