I think you should have waited for Jose's "OK". After all, we are in a feature freeze (or at least I thought we are).
Jose was not oppose to the patch and his concerns were mostly addressed. Committing the patch made testing a lot easier, and I was ready to improve or reverse the patch.
Anyway, the compiler complains about an unused parameter mouse_hover in insetbase.h:185. Can you get rid of that, please?
Fixed.
In testing, however, I found a reproducible crash:
This bug is *unrelated* to my patch. It is easy to reproduce: inset a note, copy a bunch of them, open/collapse, select etc. Then, an assertion error. I have added this to Status.15x. Other than default colors, about which I am open to suggestions, the only remaining issue is performance. It would be idea to use inset level or paragraph level repaint, but this is not possible given the current redraw mechanisms. I will keep an eye on this area. Cheers, Bo
