Georg Baum wrote:
Abdelrazak Younes wrote:
Georg Baum wrote:
Abdelrazak Younes wrote:
By the way, around section 6.2 of the UserGuide there are some accent
characters which are bigger than 65536.
Which ones? I suspect that something is going wrong there.
I'll investigate.
Thanks.
Shall I add an assertion for
those cases?
Yes.
But then it would crash...
Of course, but I don't think that reading random stuff from memory is
better.
Understood. I'll put the assert now then but this means that scrolling
UserGuide past section 6.2 will not be possible and that this needs to
be fixed RSN.
PS: magic numbers are evil
If these are magic codes for some accent unknown characters when I guess
I should simply ignore them not assert on them. Am I missing something?
I mean the magic numbers -1000 and 65536 that you added in your patch. No
magic character codes are passed to metrics AFAIK.
Ah... With a C-ish table you don't have much choice. Previously it was
-1 because of width of -1 doesn't make sense. But it does make sense for
ascend or descend. I'll put a const to clarify that.
Abdel.
