Georg Baum wrote:
> [EMAIL PROTECTED] wrote:
> 
>> Author: kuemmel
>> Date: Wed Nov 29 22:36:39 2006
>> New Revision: 16110
>>
>> URL: http://www.lyx.org/trac/changeset/16110
>> Log:
>> Fix crash on Mac, now the strange part
>>   Part 2: avoid pure virtual function,
>>           if (theApp)
>>                theApp->unregisterSocketCallback(fd_);
>>           does not help, we've tested it!
>>           Without a Mac it is hard to find a better solution
> 
> Please add a similar comment to the code. Otherwise nobody will know why
> this strange construct is needed.

I think I could revert this patch today after some testing of Bennett.

> 
> BTW the test above would help for sure if you set theApp to 0 after it is
> destructed.

The problem was (I hope) that application_ was reseted without setting
theApp to 0, so the test of theApp doesn't work. Because of this I've
remove theApp.

I will do more on this later today.

Peter

Reply via email to