Enrico Forestieri wrote:
> On Wed, Nov 29, 2006 at 05:30:36PM +0100, Peter Kümmel wrote:
>> Enrico Forestieri wrote:
>>> On Wed, Nov 29, 2006 at 03:49:31PM +0100, Peter Kümmel wrote:
>>>> Enrico Forestieri wrote:
>>>>> I am not so sure, but yes, now that I know it is a Qt4 limitation I
>>>>> could try to implement it. After all, I don't want that you make the
>>>>> work for me ;-)
>>>> But I have done. ;-)
>>> I owe you a beer, Peter!
>> Next time when I'm in Italy ;)
> 
> Promised!
> 
>>> +#if defined(_WIN32) || (defined(__CYGWIN__) && defined(X_DISPLAY_MISSING))
>> AH, here shell_type shell() does not work.
>> Should we add something like usingWin32Frontend() to os.h?
> 
> This would eliminate the need for #ifdef's, indeed, confining them
> to the os_*.C files. 
> 

But we should do it with another patch, first I commit
your patch with the FIXME comment. And then we will see,
it's a more general question how to avoid the macros.

-- 
Peter Kümmel

Reply via email to