Abdelrazak Younes wrote:
Kornel Benko wrote:
Am Dienstag, 28. November 2006 16:20 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
Bennett Helm wrote:
2. Crash: load User's Guide. Page down to the bottom, then page up
several times. LyX crashes. Here's the backtrace:
This is because I did not take into account potential changed
graphics height in redoParagraph(). You know, when the graphics is
changed from "Not open" to a fully loaded state.
The easiest solution I came up with is to let InsetBase::metrics()
return a boolean (true if changed). This modification will be needed
anyway for further optimisation.
It's compiling right now, I'll commit once I've tested it.
OK, tested and committed. The commit is big but purely mechanical. I
made use of the additional information in redoParagraph() already but
much more is possible.
Unfortunately I cannot confirm better working :(
The crash I have here is with User's Guide, _one_ page up from botton.
(updated 5 minutes ago)
I know, this was just part of the fix. The problem is a a bit more
complicated. Basically, getPitNearY() does not find the correct pit()
because of a mismatch between the graphics size and what is searched.
The problem is that getPitNearY() only looks in the cache and because I
removed the cache of the previous paragraph, it is not there.
I am experimenting some solutions right now...
This is fixed now. I reused the former solution in rowpainter.C but now
this is done automatically on-the-fly.
For 1.6, we should push for relative coordinates inside insets. This
change alone would bring a _lot_ of speed.
Abdel.
