On Mon, Nov 13, 2006 at 11:02:21PM +0000, José Matos wrote: > On Monday 13 November 2006 8:11 pm, Enrico Forestieri wrote: > > > > I fixed it. This led me to the following issue. It seems that the boolean > > values True and False were introduced in python 2.3, but we are using them > > in the 1.4.x configure.py. Giving that the minimum required python version > > for LyX 1.4.x is 2.2, should we fix this issue, or simply require 2.3? > > Look into lib/scripts/lyxpreview_tools.py for 1.4.x > The following chunk fixes this: > > # compatibility with python 2.2 > if sys.version_info[:3] == (2, 2, 0): > __builtin__.True = (1 == 1) > __builtin__.False = (1 == 0) > def bool(value): > """Demote a value to 0 or 1, depending on its truth value > > This is not to be confused with types.BooleanType, which is > way too hard to duplicate in 2.1 to be worth the trouble. > """ > return not not value > __builtin__.bool = bool > del bool > # end compatibility chunk > > Now that I see this in more detail I see that it wrong the first test > should > be: > if sys.version_info[:2] == (2, 2) > > I should prepare a patch for 1.4.
I could do it, if you don't mind. -- Enrico
