Peter Kümmel wrote:
Ah, I've overlooked it, but it must be "review" "review,top"
if not the flag ToolbarBackend::REVIEW will not be set on the
CT toolbar.
No, it can stay "review" "off,top". Users are able to activate it at
run-time if they like it.
(Before we start another discussion on optimal default values, let's see
what Bo has to offer)
I guess that you want to activate the toolbar if you are in CT mode. The
attached patch fixes this...
I also want to prepare the context sensitive solution and the "disable by menu"
solution. But we still have to decide which way to go.
Can you think of another trigger for the review toolbar?
void LyXView::updateToolbars()
{
- bool const math = work_area_->bufferView().cursor().inMathed();
+ bool const math =
+ work_area_->bufferView().cursor().inMathed();
bool const table =
lyx::getStatus(FuncRequest(LFUN_LAYOUT_TABULAR)).enabled();
- // TODO: How should we handle the CT toolbar?
- bool const change_tracking = true;
+ bool const review =
+ lyx::getStatus(FuncRequest(LFUN_CHANGES_TRACK)).enabled() &&
+ lyx::getStatus(FuncRequest(LFUN_CHANGES_TRACK)).onoff(true);
I don't like to see the CT toolbar all the time, but no problem, now
we will wait for Po's comments/patch.
???
The code snippet above activates the toolbar only if you are in CT mode.
As said before, let's wait for Bo and his solution.
Michael
