Bo> It is defined in BufferView.h. It saves current buffer's name and
Bo> position, and switch to another buffer (without title change,
Bo> which requires access to LyxView) if needed. This does not work
Bo> with multiple windows (as far as I can tell.).

I see it now. So either saved_positions should be moved to some global
object or to Buffer. I do not care either way personally, but I agree
that BufferView is wrong.

Thinking a bit more about it, I guess I prefer a global object (LyX?)

Given the global nature of bookmarks, I agree with that. I will see if
I can get a clean patch.

Bo> I would propose filename (without path and extension) + ": " +
Bo> paragraph number. This should provide enough hint.

We should not expose the paragraph number. It is meaningless for the
user.

We need a way to differentiate multiple bookmarks in the same buffer.
Paragraph number gives the user a sense of position. Anyway, if
filename is given, filename + bookmark number for that file should be
enough.

Bo

Reply via email to