Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| the patch...
|
| Abdelrazak Younes wrote:
| > Hello,
| > I am sure I implement that in the right way. Please someone who
| > knows about LFUNs, review the patch.
| > Abdel.
| >
|
| Index: frontends/Application.h
| ===================================================================
| --- frontends/Application.h (revision 15426)
| +++ frontends/Application.h (working copy)
| @@ -111,8 +111,8 @@
| virtual void unregisterSocketCallback(int fd) = 0;
|
| /// Create the main window with given geometry settings.
| - LyXView & createView(unsigned int width, unsigned int height,
| - int posx, int posy, bool maximize);
| + LyXView & createView(unsigned int width = 0, unsigned int height = 0,
| + int posx = -1, int posy = -1, bool maximize = false);
Why the default arguments?
Because I wanted to use the default size define in the qt4 frontend.
Default arguments often feels/looks nice, but they are a burden.
Two functions are often better.
No strong opinion about that...
Abdel.
