Georg Baum wrote:
Abdelrazak Younes wrote:
Andre Poenitz wrote:
Or maybe not. The coordcahce is for up/down navigation and vconverting
mouseclicks to text positions. It is not for pure display/export which
is whatr drawT is about.
I did not know, I thought it was also used for drawing.
So maybe Abdel is right and it was a simple oversight not to remove it
after some copying from the 'real' draw() method.
So you reckon I can just delete the line?
With this explanation I'd say so.
OK, done so and adjusted the FIXMEs:
Log:
Adjust the FIXME texts and Delete commented out setXY() call following
Andre comments about it:
The coordcahce is for up/down navigation and vconverting mouseclicks to
text positions. It is not for pure display/export which
is what drawT is about. It was a simple oversight not to remove it after
some copying from the 'real' draw() method.
Modified:
lyx-devel/trunk/src/mathed/MathData.C
lyx-devel/trunk/src/mathed/TextPainter.h
Modified: lyx-devel/trunk/src/mathed/MathData.C
URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/mathed/MathData.C?rev=15347
==============================================================================
--- lyx-devel/trunk/src/mathed/MathData.C (original)
+++ lyx-devel/trunk/src/mathed/MathData.C Mon Oct 16 11:08:05 2006
@@ -333,21 +333,8 @@
{
//lyxerr << "x: " << x << " y: " << y << ' ' << pain.workAreaHeight()
<< endl;
- // FIXME: Abdel 13/10/2006
- // The setXV() call below is commented out for now because
- // we don't have access to a BufferView at this level.
- // In any case, this drawT() method is never used, this is dead code.
- //
- /* Georg explanation of current situation:
- AFAIK the text painter was used to export math formulas as ASCII art.
- Therefore the setXY() call makes sense. Imagine that the text painter is
- like a real painter, but operating on a very coarse grid of character
cells
- where each cell can be filled with an ASCII character.
- I don't know why it is currently disabled. I do know that we have a
bugzilla
- request for reenabling it. I believe only Andre can tell whether that is
- doable or whether the whole drawT machinery should be removed.
- */
- //setXY(bv, x, y);
+ // FIXME: Abdel 16/10/2006
+ // This drawT() method is never used, this is dead code.
for (const_iterator it = begin(), et = end(); it != et; ++it) {
(*it)->drawT(pain, x, y);
Modified: lyx-devel/trunk/src/mathed/TextPainter.h
URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/mathed/TextPainter.h?rev=15347
==============================================================================
--- lyx-devel/trunk/src/mathed/TextPainter.h (original)
+++ lyx-devel/trunk/src/mathed/TextPainter.h Mon Oct 16 11:08:05 2006
@@ -16,6 +16,16 @@
#include "support/docstream.h"
#include <vector>
+
+// FIXME: Abdel 16/10/2006
+// This TextPainter class is never used, this is dead code.
+/* Georg explanation of current situation:
+AFAIK the text painter was used to export math formulas as ASCII art.
+The text painter is like a real painter, but operating on a very coarse
+grid of character cells where each cell can be filled with an ASCII
character.
+I don't know why it is currently disabled. I do know that we have a
bugzilla
+request for reenabling it.
+*/
class TextPainter {
public:
