Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Will commit tomorrow if there's no objection.
Abdelrazak> With this updated patch the two views works fine including
Abdelrazak> Cut&Paste between the two views :-)
Abdelrazak> I will commit the patch tomorrow without the temporary
Abdelrazak> code in lyx_main.C. We need to create a new LFUN for "new
Abdelrazak> view" and a new menu item.
I really really do not like this theCoords global pointer. Unless you
have firm plans to get rid of it in the near future, of course. This
is a clear cause for horrible bugs.
The fact that the bv is not known where it should be simply indicates
that the methods in questions are lacking a bv parameter. For example
InsetTabular::dist should have this parameter, which means that
InsetTabular::getNearestCell should have it too (which is not a
problem since there is a cursor around when it is called). All
these changes make sense, so they should be done.
The think is that once we add the additional argument somewhere then it
will be needed to all methods in the calling hierarchy (butterfly effect).
Passing BufferView to every method of InsetBase does not seem very clean
to me. I would prefer to add a BufferView reference member to InsetBase
filled at construction. I don't think InsetBase should be BufferView
independent but perhaps I am wrong. What do you think?
Abdel.
