Georg Baum wrote:
Abdelrazak Younes wrote:
Georg Baum wrote:
Please fix your editor. The spacing of the parameters of getRgbColor is
broken again.
I've fixed that but I am not sure it is my editor that is broken. I have
replaced the tabs by 4 spaces and I get exactly the same alignement. The
file looked OK in MSVC, tortoiseSVN editor, and WordPad.
Probably because your tab setting is equal to 4 spaces. There were 8 tabs,
and if you set your tab to be 8 characters wide then it looks strange.
I use tabs that are 8 characters wide. You seem to use 4, and Andre uses 2
IIRC. If you follow the rule
tabs for logical indentation, spaces for visual alignment
Yes, I understand that now. Thanks for the explanation.
then it will look right regardless of the tab width. In this case that means
that arguments in function declarations should be indented only with spaces
if they are ment to be aligned with the first argument. The other
laternative would be to indent all argument lines with exactly two tabs and
not align them with the first argument. That does also look OK regardless
of tab width.
I know that this rule is violated in many parts of the existing code, but I
often do not notice because a tab setting of 8 was used :-)
The latest three chars are illegal today.
Abdel.
