On Oct 4, 2006, at 5:27 AM, Jean-Marc Lasgouttes wrote:

"Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:

 Martin, could you apply that to 1.4.4svn (with proper changelogs)?

Martin> It's in... with logs and status.14x.

Thanks a lot. People, please test this hard, in particular on windows
and mac where different compilers mean different problems.

I do not want to see bugs in this code uncovered 2 days before
release.

I'm not finding any bugs, but I do see some UI oddities.

First, with a document with several nested headings, open the TOC dialog, select a heading, and click on the "In" button repeatedly. The heading in the document changes appropriately, but the heading in the TOC dialog eventually disappears -- even as you continue to click on the "In" button. Clicking on "Out" causes that heading to reappear in the dialog. This is counter-intuitive, and potentially quite confusing. Perhaps the slider in the TOC dialog ought to move to the right automatically so as to prevent the heading from disappearing. Also, there are cases in which even when the slider is moved all the way to the right, the heading disappears (because it loses its numbering). Do we want to allow the TOC dialog to manipulate the headings in these cases? I think we should either allow the manipulation only if we permit unnumbered headings to appear in the TOC dialog.

Second, I'd switch the placement of the "Out" and "In" buttons: "Out" corresponds to moving the heading "higher", or "to the left", and so it ought to be placed on the left of "In". (That would correspond to the direction of the slider, too.)

Bennett

Reply via email to