Georg Baum wrote:
Abdelrazak Younes wrote:
Index: buffer.C
===================================================================
--- buffer.C (revision 15153)
+++ buffer.C (working copy)
@@ -1480,12 +1477,13 @@
params().parentname = name;
}
-
retain the two spaces please.
+// FIXME getMasterBuffer() has no business here!
+// should be transfered to BufferList.
Buffer const * Buffer::getMasterBuffer() const
This comment is wrong. getMasterBuffer returns the master buffer of a
multipart document, not some "global master buffer" (see also the
documentation in buffer.h). It has nothing to do with bufferlist.
Indeed, I got it wrong... thanks!
Would it make sense to make a new MasterBuffer class that derives from
Buffer?
+// FIXME newFile() should be a member method of Application or
BufferList?
Not bufferlist IMHO. Bufferlist simply holds a list of open buffers.
So Application it will be.
I don't have any further complaints ;-)
Thanks for the useful complaints!
Abdel.
