Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

Abdelrazak> If there's no objection then I will proceed to 2) at the
Abdelrazak> end of the day.

That seems OK. Obviously I did not have much time to look at it but:

* lyXFunc is an horrible name :)

Suggestion?


* this looks wrong:

+void Application::setBufferView(BufferView * buffer_view)
+{
+       buffer_view_ = buffer_view_;
+}

You're right but it is necessary for now. This is used for the X11 selection. Application needs to know know which BufferView is "current". I plan to get rid of this entirely by implementing Gui::currentView() and LyXView::currentWorkArea(). Then, the selection request/clear code in GuiApplication just need to access the "current" BufferView via:

gui_.currentView().currentWorkArea()

In addtion, the "current" BufferView i.e. the one that has the focus could also always be accessible through theApp->currentBufferView() if needed (not sure it is though).

Abdel.

Reply via email to