Georg Baum wrote:
Abdelrazak Younes wrote:

So you would be OK if I change also all code that deals with format names?

The question is: Do non-ASCII format names make sense? I really don't know.

Me neither but probably not. Unless a Chinese user for example use a format is not defined in ASCII... Why not actually?

If the answer to that question is yes and it does not create problems
elsewhere, then it would be OK with me.

In this case, I think the format should be an enum instead.

enum FileFormat {
jpg,
lyx,
etc
};

Won't work. Users can add their own formats.

Then we need docstring as we don't know which kind of extension a user could create.

We could of course create an
enum for know formats and a userdefined value, but that would make the code
more ugly.

You're right, forget about it.

Abdel.

Reply via email to