On Fri, Sep 08, 2006 at 03:24:56PM +0100, Ozgur Ugras BARAN wrote:
> and last of all, I developed this against the lyx 1.5.x. However, (if
> insetCommandParams mod. is correct) there is no reason not to add this
> functionality in lyx 1.4.x
> 
> with my kindest regards,

As usual: Things about which I don't complain are fine with me:

- * \author Lars Gullik Bjønnes
+ * \author Lars Gullik Bjnnes
- * \author André Pönitz
+ * \author Andr�P�itz
- * \author José Matos
+ * \author Jos�Matos
- * \author Jürgen Vigna
+ * \author Jrgen Vigna

Not sure you'll get much support for this part...

  *
  * Full author contact details are available in file CREDITS.
  */
@@ -383,6 +383,12 @@
                packages << "\\usepackage[dot]{bibtopic}\n";
        }
 
 void InsetCommandParams::scanCommand(string const & cmd)
 {
-       string tcmdname, toptions, tsecoptions, tcontents;
+       string tcmdname, toptions, tsecoptions, tcontents,tseccontents;

Space before tsec*

                        state = WS;
                }
-               if ((state == OPTION  && c == ']') ||
-                   (state == SECOPTION  && c == ']') ||
-                   (state == CONTENT && c == '}')) {
-                       if (nestdepth == 0) {
-                               state = WS;
-                       } else {
-                               --nestdepth;
-                       }
+               if((state == OPTION && c == ']')||

Space after if and before ||

-               if ((state == OPTION  && c == '[') ||
-                   (state == SECOPTION  && c == '[') ||
-                   (state == CONTENT && c == '{')) {
+               if((state == OPTION && c == '[')||
+                  (state == CONTENT && c == '{')) {

Same, more following.

-       void setSecOptions(std::string const & s) { sec_options = s; }
+       void setSecOptions(std::string const & s) { sec_options = s;    if 
(lyxerr.debugging(Debug::PARSER))
+               lyxerr << "Sec options set as <" <<  s;
+}

'Non trivial' implementation please in the .C unless proven necessary by
the profiler.

Wrt to the parsing, it doesn't look wrong but should be checked with
'traditonal' [][]{} insets followed by {} in ERT. If that's ok I see no
problem.

Andre'

Reply via email to