>>>>> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes:
Juergen> I would like to see this code it would interst me what you
Juergen> did to call KDE_DO_IT_ALL only if the --with-frontend=kde is
Juergen> set.
>> OTOH, I am concerned by the fact that this KDE autoconf stuff does
>> many things we already do, and that some things that go in config.h
>> could create conflicts. We'll see over time.
>>
Basically, I removed everything but the call to LYX_USE_FRONTEND in
configure.in, and changed the macro to the following:
### Check which frontend we want to use. The default is XForms
###
AC_DEFUN(LYX_USE_FRONTEND,
[AC_MSG_CHECKING(what frontend should be used as main GUI)
AC_ARG_WITH(frontend,
[ --with-frontend[=value] Use THIS frontend as main GUI:
Possible values: xforms,kde],
[lyx_use_frontend="$withval"], [lyx_use_frontend="xforms"])
AC_MSG_RESULT([$lyx_use_frontend])
lyx_flags="$lyx_flags frontend-$lyx_use_frontend"
case "$lyx_use_frontend" in
kde)
KDE_DO_IT_ALL
FRONTEND="kde"
FRONTEND_GUILIB="\${top_builddir}/src/frontends/kde/libkde.la"
FRONTEND_LDFLAGS="\$(QT_LDFLAGS) \$(KDE_LDFLAGS)"
FRONTEND_INCLUDES="\$(QT_INCLUDES) \$(KDE_INCLUDES)"
FRONTEND_LIBS="\$(KDE_LIBS)"
AC_DEFINE(KDEGUI);;
xforms)
FRONTEND="xforms"
FRONTEND_GUILIB="\${top_builddir}/src/frontends/xforms/libxforms.la";;
*)
LYX_ERROR(Unknown frontend $lyx_use_frontend);;
esac
AC_SUBST(FRONTEND)
AC_SUBST(FRONTEND_GUILIB)
AC_SUBST(FRONTEND_LDFLAGS)
AC_SUBST(FRONTEND_INCLUDES)
AC_SUBST(FRONTEND_LIBS)
])
I am not sure it works (since I can't test it), but the idea should be
correct. Basically, the differences are the way the default xforms
value is obtained (arg4 of AC_ARG_WITH) and the case to avoid bogus
values. It does the same, but is cleaner.
Juergen> Well what does it write inside config.h you don't like? I
Juergen> don't care if we remove that. It's possible that I test some
Juergen> things we already do, but does this really mater?
I don't know. Just that I think there are many things there and I do
not like those kde macros which do many things I'm not sure we need,
like:
- gettext
- K_PATH_X which does something different from AC_PATH_X
(which we already have called at this point) although we do not know
what exactly
- KDE_CHECK_EXTRA_LIBS does something we already do (--with-extra-xxx)
- check for setenv (we have one, and do not know whether theirs is
better/worse)
- AC_CHECK_COMPILERS does something we already do
- KDE_PROG_LIBTOOL. What does it do?
It seems that some of these functions are actually not used. We could
maybe try to remove them from kde.m4 and see whether our situation improves.
Juergen> I connect over pserver (rsh) too, ..., test, AND have the
Juergen> same problems like you just now! Probably we have to contact
Juergen> Lars for this. I did not try to commit anything but I guess I
Juergen> cannot do it too :(
I already sent a message to Lars. No answer yet.
JMarc
