Re: New file patch (was: Re: Just a Matter of Style (was: LaTeX file handling))

[Arnd Hanses]

On Mon, 09 Aug 1999 18:35:10 +0900, Shigeru Miyata wrote:

Thank you very much for the fast answer; I'm always grateful for
criticism:

>"Arnd Hanses" <[EMAIL PROTECTED]> wrote:
>
>>         temp = AddName( OnlyPath(file), temp );
>> 
>>         // Replace spaces with underscores, also in directory
>>         temp.subst(' ','_');
>
>This is wrong!  You must not rename the file you may not be the
>creator.

Unfortunately this is not my code, I left this unchanged because I must
admit, I do not fully understand what it is doing. I understand the
functions, but I do not know why the original author has chosen to
alter the files name in the system. As those two lines are really the
only ones not being changed (apart from reformatting perhaps), within
this method, the diff utility probably got confused and did no good job
here, so you cannot see the authorship.

>> Note:
>> I'm not sure why, but gcc -Wall doesn't give a damn warning in case of
>> suspicious code like this:
>> 
>>         LString foo = (char*)bar;
>> 
>> Shouldn't there be one and how can this be achieved?
>
>The LString class overrides the asignment operator "=".  You do not
>have to cast twice.

I've seen often the double cast in the code: 

         LString foo = LString (bar);

What would be the best coding style in those cases?

Regards,

        Arnd Hanses