>>>>> "Arnd" == Arnd Hanses <[EMAIL PROTECTED]> writes:

Arnd> Can't you simply detete that? Or cut and paste by hand? The
Arnd> patch should be simple to read and understand. In fact there are
Arnd> only five or six lines of code changed.

I began to apply it and have two questions:

1/ The indentation of the following code is strange; doesn't it need
some braces?

+                        if (sh.empty())
+                                // COMSPEC is set, unless user unsets 
+                                sh = OnlyFilename(getEnvPath("COMSPEC"));
+                               if (sh.empty())
+                                       sh = "cmd.exe";

2/ Why do you comment out the code when need_shell is false?

-       } else {
-               minibuffer->Set(_("Executing command:"), cmd);
-               result = one.Startscript(wait ? Systemcalls::Wait
-                                       : Systemcalls::DontWait, cmd);
+//     } else {
+//             minibuffer->Set(_("Executing command:"), cmd);
+//             result = one.Startscript(wait ? Systemcalls::Wait
+//                                     : Systemcalls::DontWait, cmd);

JMarc

Reply via email to