> In lyx_cb.C, AutoSave() has the following code, 
> 
>         if (current_view->currentBuffer()->isBakClean()
>                 || current_view->currentBuffer()->isReadonly())
>                 return;

> while in BufferList::QwriteAll(), we have a test like:
> 
>                 if (!b->isLyxClean()) {
>                         switch(AskConfirmation(_("Changes in document:"),
>                                                MakeDisplayPath(b->filename,50),
>                                                _("Save document?"))) {
> 
> 
> Which test is the right one? Shouldn't we use isLyxClean() for
> AutoSave? I did not make the change myself because (1) I forgot and
> (2) AutoSave is a part of the code I don't want to fiddle with (don't
> know why, really).

IMO, we should use "isLyxClean()", and "isReadonly()" (it's possible to
change the status of a changed document to make it read-only, but then
I don't think we should autosave it...)

I don't know what isBakClean does.  You might want to check the logic
of that and see if we need that as well.

Greets,

Asger

Reply via email to