> Perhaps this is the more correct option. Hmmm... The main reason for the
> changes in the first place was the bizarre combinations of toggling in the
> character popup. So perhaps we should make the popup an exception.
I think we should make the popup set, not toggle. The rest should toggle
(regardless of the setting in the pop-up.).
If we need a global variable for this, I don't mind. This is the 1.0.x branch,
and it's going to die soon.
Of course, it should be perfectly possible to do this without a global
variable, but if Joacim is going to do it, he can do it the way he thinks is
best. My judgement is that it is easiest to introduce another lyx-command that
always toggles. This command can possibly exploit the existing command, and
cache the value of the toggle switch meanwhile:
void new_bold_toggle {
bool old_toggle_setting = toggle_switch_in_popup;
toggle_switch_in_popup = true;
font-set(bold);
toggle_switch_in_popup = old_toggle_setting;
}
I just feel that it's a fundamental feature that should work the best way
possible.
Greets,
Asger
