>>>>> "Etienne" == Etienne Grossmann <[EMAIL PROTECTED]> writes:
Etienne> I have appended a patch (against pre7) for the "Bis"
Etienne> behavior. I prefer "Bis" over "New".
OK, it looks good. One minor thing, though:
Etienne> +// A character
Etienne> that's not a separator, comma, etc is in a word. +#define
Etienne> WORDCHAR(x) (!( (x).par->IsSeparator((x).pos) \ + ||
Etienne> (x).par->IsKomma((x).pos) \ + || (x).par->IsHfill((x).pos) \
Etienne> + || (x).par->IsFloat((x).pos) \ + ||
Etienne> (x).par->IsInset((x).pos)))
This should certainly not be a macro (we try to avoid them as much as
possible, in fact). Could you change it to an inline function and put
this function in textutil.h, along with the others? In fact, the right
thing to do is:
define
bool IsWordChar(unsigned char c)
in textutil.h, and maybe define
LyXParagraph::IsWordChar(int pos)
which uses the previous definition.
This is how the other things are done anyway, so I think we should
stick to that.
JMarc
